Conversation
aram356
requested changes
Jan 26, 2026
Collaborator
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
👍 Looks good overall. Some improvement will get us closer to consistency. Thanks
prk-Jr
force-pushed
the
191-standardize-error-handling-patterns-choose-between-reporttrustedservererror-and-bare-trustedservererror
branch
from
b3943d2 to
d691060
Compare
Unified error reporting across storage and signing modules allows for better debugging and traceability. Bare error enums previously lacked context on where failures originated. Using meaningful reports with attached context ensures that logs provide actionable information for operations teams without requiring changes to the core error variants. Resolves: #191
Using on errors that are already of the correct type causes redundant nesting in the error report. This switches to to add context without changing the error type, producing cleaner error chains. Resolves: #191
prk-Jr
force-pushed
the
191-standardize-error-handling-patterns-choose-between-reporttrustedservererror-and-bare-trustedservererror
branch
from
d691060 to
cb3f36a
Compare
ChristianPavilonis
approved these changes
Jan 28, 2026
…se-between-reporttrustedservererror-and-bare-trustedservererror
aram356
deleted the
191-standardize-error-handling-patterns-choose-between-reporttrustedservererror-and-bare-trustedservererror
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified error reporting across storage and signing modules allows for better debugging and traceability. Bare error enums previously lacked context on where failures originated. Using meaningful reports with attached context ensures that logs provide actionable information for operations teams without requiring changes to the core error variants.
Resolves: #191